Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix build #265

Closed
nemesifier opened this issue Jan 25, 2021 · 2 comments · Fixed by #267
Closed

[CI] Fix build #265

nemesifier opened this issue Jan 25, 2021 · 2 comments · Fixed by #267
Assignees
Labels
bug Something isn't working

Comments

@nemesifier
Copy link
Member

Fix the build on github actions, which is failing.

@nemesifier nemesifier added the bug Something isn't working label Jan 25, 2021
@nepython
Copy link
Contributor

The build is failing because influxdb container might be taking longer than 15s to start on the CI.
@nemesisdesign, I think initially we had similar issue which we dealt with in #23.
I tried out the below steps locally to confirm if the changes introduced in #23 are still effective.

$ sudo service influxdb stop
$ ./tests/manage.py makemigrations --dry-run monitoring
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 1 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 2 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 3 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 4 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 5 out of 5).
Traceback (most recent call last):
# and the urllib3 exception follows

@nemesifier
Copy link
Member Author

The build is failing because influxdb container might be taking longer than 15s to start on the CI.
@nemesisdesign, I think initially we had similar issue which we dealt with in #23.
I tried out the below steps locally to confirm if the changes introduced in #23 are still effective.

$ sudo service influxdb stop
$ ./tests/manage.py makemigrations --dry-run monitoring
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 1 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 2 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 3 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 4 out of 5).
Got error while connecting to timeseries database. Retrying again in 3 seconds (attempt n. 5 out of 5).
Traceback (most recent call last):
# and the urllib3 exception follows

I don't see this output in the build output: https://github.com/openwisp/openwisp-monitoring/runs/1738993241

@devkapilbansal can you look into it when possible?
Also, I didn't notice this, but why is the redis service declared also in the deploy step, is it needed there?

@devkapilbansal devkapilbansal self-assigned this Jan 28, 2021
devkapilbansal added a commit to devkapilbansal/openwisp-monitoring that referenced this issue Jan 28, 2021
- Added extra name option for influxdb image
- Change image to influxdb:alpine
- Remove unused redis

Fixes openwisp#265
nemesifier pushed a commit that referenced this issue Jan 28, 2021
- Added extra name option for influxdb image
- Change image to influxdb:alpine
- Remove unused redis

Fixes #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants