[api] Implement ScopedRateThrottle by default #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloCastellano
force-pushed
the
api-scopedratethrottle
branch
2 times, most recently
from
19b245c
to
614107d
Compare
PabloCastellano
force-pushed
the
api-scopedratethrottle
branch
from
614107d
to
14eff1c
Compare
nemesifier
requested changes
May 21, 2020
|
|
||
| def add_default_menu_items(self): | ||
| menu_setting = 'OPENWISP_DEFAULT_ADMIN_MENU_ITEMS' | ||
| items = [ | ||
| {'model': 'test_project.Shelf'}, | ||
| ] | ||
| setattr(settings, menu_setting, items) | ||
|
|
||
| def configure_drf_defaults(self): |
There was a problem hiding this comment.
I'm also thinking that this method could be part of a mixin which we could import in the other modules so we don't need to redefine it each time, we will just add the mixin to the AppConfig class, or alternatively we can define a function and call that function in the modules (instead of using the mixin, which some people don't like, I'm fine with both approaches).
nemesifier
reviewed
May 26, 2020
There was a problem hiding this comment.
@PabloCastellano when the code coverage drops so much, it means the code being added is not being used, which seems to be the case.
Leave this to me, I will improve it.
NoumbissiValere
pushed a commit
that referenced
this pull request
Jul 27, 2020
Improves and closes #112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of openwisp/openwisp-firmware-upgrader#48
Note that by using ScopedRateThrottling it requires us to define a default anon class throttle for the unauthenticated API requests.