Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Moved CI to GitHub Actions #169

Merged
merged 2 commits into from
Jan 30, 2021
Merged

[qa] Moved CI to GitHub Actions #169

merged 2 commits into from
Jan 30, 2021

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jan 28, 2021

No description provided.

@pandafy
Copy link
Member Author

pandafy commented Jan 28, 2021

@purhan @devkapilbansal can you help me debug why the coverage task is failing?

Copy link
Contributor

@purhan purhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 👍

Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor changes below:

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart minor issues below.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@atb00ker atb00ker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@nemesifier nemesifier merged commit 2f9066e into master Jan 30, 2021
@nemesifier nemesifier deleted the github-actions branch January 30, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants