[qa] Minor improvements of naming of migration check

[nemesifier]

No description provided.

[coveralls]

Coverage decreased (-0.4%) to 92.857% when pulling dddd542 on qa into 42ffbb9 on master.

[nemesifier]

@atb00ker check when you can

[atb00ker]

One question for call_check_migration_name(); actually, i named it initialize() because i thought there are more tests that can be called from initialize() ( like checking if there are pending migrations -- or any such django related test we might in need in future ).

Hence, with that in mind, i added args.no_migration_check to give user the option to avoid check_migration_name. However, if call_check_migration_name() is only planned to call check_migration_name(), that option is obsolete. (and maybe that code in a separate function doesn't make sense.)

Should i change it accordingly ?

[nemesifier]

@atb00ker yes in general is a good practice to avoid adding logic unless extremely needed. We can add it back in the future if we need to, or we can create a directory qa with more checks, every check running in its own file, we may have only one initialize function if we feel that makes sense, not sure.. at the moment I'm just concerned with keeping the code readable, simple and easy to maintain.

You may have noticed that as the project grows the complexity also grows and we need to do our best to add complexity only when it's extremely needed or we'll quickly lose control.

I have given you write access to this repo so you can edit the branch where I pushed these changes.

[atb00ker]

Removed option --no-migration-check, function call_migration_name_check() and test cases rendered obsolete due to changes. 😄