Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Added an option to ignore files #299 #357

Conversation

shubham-yadavv
Copy link
Contributor

@shubham-yadavv shubham-yadavv commented Oct 3, 2023

Changes

Add an option to ignore files in openwisp-qa-check

Closes #299

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubham-yadavv Thanks! Please check the QA check failures in the build

@@ -195,6 +199,7 @@ MIGRATIONS_TO_IGNORE="0"
COMMIT_MESSAGE=$(git log $TRAVIS_PULL_REQUEST_SHA --format=%B -n 1)
FAILURE=0
MODULE=""
IGNORE_PATTERN=" "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why " " and not ""?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh correct there should not be space btween the double quotes

@shubham-yadavv
Copy link
Contributor Author

@nemesifier can you help me with QA check failures in the build?

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's litterally written in the build failure log:

Your commit message does not follow our commit message style guidelines:

  • please add a capital letter after the prefix

That means:

[prefix] fix bug > [prefix] Fix bug

@shubham-yadavv shubham-yadavv changed the title [feature] added an option to ignore files #299 [feature] Added an option to ignore files #299 Oct 6, 2023
@shubham-yadavv shubham-yadavv deleted the option-to-ignore-file-#299 branch October 6, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[change] Add an option to ignore files in openwisp-qa-check
2 participants