Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple navigation menu #5

Closed
wants to merge 2 commits into from

Conversation

hizkifw
Copy link

@hizkifw hizkifw commented Dec 11, 2017

This PR adds a simple collapsible menu, styled with some animations and support for tab navigation.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 099964a on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 6726b28 on HizkiFW:master into d742d47 on openwisp:master.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hizkifw good start!

We'll focus on the design part in this task and I will create a new task to improve the django side (user permissions etc) after we are done with this.

Can you add a menu icon that is now very common among that type of menu?

I would like to keep only the links to the following items (in this order):

  • Home (link to index)
  • Device
  • Templates
  • VPN Servers
  • Certification Authorities (CAs, but we can use the extended form here)
  • Certificates
  • Users
  • Groups
  • Organizations

Can you make each link like a square button? Like this website here (resize the window to make it narrow and the menu on the right will show up).

Any other improvement that will make the menu similar to the example I provided is welcome!

padding: 0 20px;
float: left;
background-color: #353535;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add blank line

#nav-activate:hover {
background-color: #222;
}
#nav-activate:focus {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add blank line

#nav-activate:focus {
outline: none;
}
#nav-top {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add blank line

background-color: #353535;
transition: all .5s;
z-index: 999;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add blank line

font-weight: bold;
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove blank line

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 8aadf77 on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 5e36000 on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling db137b6 on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 39d57f7 on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 6ddcd85 on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 70479a9 on HizkiFW:master into d742d47 on openwisp:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.845% when pulling 34e1ed7 on HizkiFW:master into d742d47 on openwisp:master.

@hizkifw hizkifw force-pushed the master branch 4 times, most recently from 3baab92 to 0cd8267 Compare December 18, 2017 09:41
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hizkifw could you squash the commits into two (one for frontend and one for backend) please?

@hizkifw
Copy link
Author

hizkifw commented Dec 20, 2017

@nemesisdesign Commits squashed

@@ -1,8 +1,8 @@
from django.contrib import admin
from django.contrib.admin import *
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant. As we've already imported admin from django.contrib

@@ -96,3 +96,44 @@ class TimeReadonlyAdminMixin(object):
def __init__(self, *args, **kwargs):
self.readonly_fields += ('created', 'modified',)
super(TimeReadonlyAdminMixin, self).__init__(*args, **kwargs)

class MyAdminSite(AdminSite):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can make it admin.AdminSite

@nemesifier nemesifier closed this Nov 29, 2019
OpenWISP Contributor's Board automation moved this from In progress to Done Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants