[docs] Documents openwisp-utils-qa-checks #47 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atb00ker
reviewed
Dec 28, 2019
atb00ker
requested changes
Dec 28, 2019
There was a problem hiding this comment.
- Rebase with master.
mastercontainsopenwisp-utils-qa-checkssection. Improve on that.- Please document all the options as well. (for all the
openwisp-utils-qa-checksas well, likecommitcheck,migration name check) You'll have to read some of the code for that as well!
|
@atb00ker Ah I see, it must’ve been added after I made my commit (was away for a few days so couldn’t push immediately) |
Some options are not documented, please read the code & testcases for all the tests, it should help you find out, when you think you've found all of them, mark for review and I'll double check to let you know! 😄 |
talha-p
force-pushed
the
qa-docs
branch
2 times, most recently
from
b44f619
to
c23205d
Compare
atb00ker
reviewed
Dec 30, 2019
README.rst
Outdated
| The following quality assurance checks are ran in openwisp-utils-qa-checks: | ||
|
|
||
| * ``checkmigrations`` (Read more below) | ||
| * ``checkcommit`` (Read more below) |
talha-p
force-pushed
the
qa-docs
branch
3 times, most recently
from
f756ec8
to
6f09481
Compare
This commit adds openwisp-utils-qa-checks to the README file and describes its purpose. It also includes checkendline Fixes openwisp#47
nemesifier
reviewed
Jan 2, 2020
nemesifier
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds openwisp-utils-qa-checks to the README file and describes its purpose. It also includes
checkendlineFixes #47