adding django2.0 compatibility. #9
Conversation
|
maybe mentor will say this is wrong |
There was a problem hiding this comment.
@gandhi23 We'll need to make sure it is compatible with both django 2.0 and django 1.11. So we shouldn't remove the 1.11 check.
There was a problem hiding this comment.
@rohithasrk is right.
Plus I see too many unnecessary changes. I suggest to start from scratch and change the least possible lines.
Please use a better commit message as outlined in our guidelines:
http://openwisp.io/docs/developer/contributing.html#commit-and-push
|
@rohithasrk for ur kind notice, django2 is not backward-compatible with previous django versions. So, it is impossible to add both. :) |
2 similar comments
|
@nemesisdesign only necessary change have been made. if not, please say the specific changes to be made in chat or here. |
|
@gandhi23 It is only true for some of the changes. Not all of django2.0 is different from django1.11 |
|
Check out this https://github.com/netjson/django-netjsongraph |
Changes have been made to openwisp-utils directory to add django2 compatibility. This is a part of my google code-in task: https://codein.withgoogle.com/dashboard/task-instances/5332094102274048/