[fix] Fixed setting properties that could be an integer or string in …

…newer versions of Ruby (5m)
openxml · Feb 19, 2024 · 127a496 · 127a496
1 parent 4498cdb
commit 127a496
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/openxml/drawingml/properties/percentage_property.rb b/lib/openxml/drawingml/properties/percentage_property.rb
@@ -4,7 +4,7 @@ module Properties
       class PercentageProperty < ValueProperty
 
         def valid?
-          value =~ OpenXml::DrawingML::ST_Percentage
+          value.is_a?(String) && value =~ OpenXml::DrawingML::ST_Percentage
         end
 
         def invalid_message

diff --git a/lib/openxml/drawingml/properties/space_after.rb b/lib/openxml/drawingml/properties/space_after.rb
@@ -12,7 +12,7 @@ class SpaceAfter < SimplePropertyContainerProperty
 
         def initialize(value)
           super()
-          target_property = value =~ /%/ ? :spacing_percent= : :spacing_points=
+          target_property = value.is_a?(String) && value =~ /%/ ? :spacing_percent= : :spacing_points=
           public_send(target_property, value)
         end
 

diff --git a/lib/openxml/drawingml/properties/space_before.rb b/lib/openxml/drawingml/properties/space_before.rb
@@ -12,7 +12,7 @@ class SpaceBefore < SimplePropertyContainerProperty
 
         def initialize(value)
           super()
-          target_property = value =~ /%/ ? :spacing_percent= : :spacing_points=
+          target_property = value.is_a?(String) && value =~ /%/ ? :spacing_percent= : :spacing_points=
           public_send(target_property, value)
         end