Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TracingPropagationExecInitializer searching for wrong class in registry entries. #14

Closed
kirenjolly opened this issue Feb 14, 2019 · 4 comments · Fixed by #15
Closed

Comments

@kirenjolly
Copy link
Contributor

kirenjolly commented Feb 14, 2019

init function in TracingPropagationExecInitializer is trying to get HttpTracing.class from the execution object i pass but instead it should maybeGet(TraceContextHolder.class).
Since in my registry entries only this is present.
RegistryEntry{type=ratpack.zipkin.internal.RatpackCurrentTraceContext$TraceContextHolder, value=ratpack.zipkin.internal.RatpackCurrentTraceContext$TraceContextHolder@6139672b}.
Hence httpTracing is always null in init.

So init can't be used for manual setting of TraceContext on passing the current Execution because at that point RatpackCurrentTraceContext$TraceContextHolder will be having the CurrentTraceContext and not HttpTracing.class

@kirenjolly
Copy link
Contributor Author

kirenjolly commented Feb 14, 2019

@devinsba @llinder Please Correct me if i am wrong. Because this function(init) is what we are using as a workaround for context propagation in ratpack promises and async calls

@codefromthecrypt
Copy link

can you raise a pull request? it looks like you know where the problem might be

@codefromthecrypt
Copy link

basically if you can put a test that fails until a change is made.. and also that change. it will be a great way of unblocking yourself :P

@kirenjolly
Copy link
Contributor Author

kirenjolly commented Feb 15, 2019

Yeah i will create a test for both the cases and raise a PR for that.

kirenjolly pushed a commit to kirenjolly/brave-ratpack that referenced this issue Feb 15, 2019
This was referenced Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants