-
Notifications
You must be signed in to change notification settings - Fork 4
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TracingPropagationExecInitializer searching for wrong class in registry entries. #14
Comments
can you raise a pull request? it looks like you know where the problem might be |
basically if you can put a test that fails until a change is made.. and also that change. it will be a great way of unblocking yourself :P |
Yeah i will create a test for both the cases and raise a PR for that. |
kirenjolly
pushed a commit
to kirenjolly/brave-ratpack
that referenced
this issue
Feb 15, 2019
…rrent context on creating new spans, closes openzipkin-contrib#14
This was referenced Feb 21, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
init
function in TracingPropagationExecInitializer is trying to getHttpTracing.class
from the execution object i pass but instead it shouldmaybeGet(TraceContextHolder.class)
.Since in my registry entries only this is present.
RegistryEntry{type=ratpack.zipkin.internal.RatpackCurrentTraceContext$TraceContextHolder, value=ratpack.zipkin.internal.RatpackCurrentTraceContext$TraceContextHolder@6139672b}
.Hence httpTracing is always null in
init
.So
init
can't be used for manual setting of TraceContext on passing the currentExecution
because at that pointRatpackCurrentTraceContext$TraceContextHolder
will be having theCurrentTraceContext
and notHttpTracing.class
The text was updated successfully, but these errors were encountered: