New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More accurate OkHttp3 / Okio version management for OSGi deployments #1285

Merged

codefromthecrypt merged 1 commit into openzipkin:master from reta:okhttp3.osgi.versions

Dec 24, 2020

Contributor

reta commented Dec 23, 2020

At the moment, the OkHttp3 and Okio versions are unspecified in OSGI manifests.

Import-Package: brave;version="[5.12,6)",brave.http;version="[5.12,6)",brave.internal;braveinternal=true;version="[5.12,6)",brave.propagation;version="[5.12,6)",okhttp3,okio

Since Zipkin OkHttp3 instrumentation supports OkHttp3 3.x and 4.x, more accurate version management would be helpful.

Import-Package: brave;version="[5.12,6)",brave.http;version="[5.12,6)",brave.internal;braveinternal=true;version="[5.12,6)",brave.propagation;version="[5.12,6)",okhttp3;version="[3.11,5)",okio;version="[1.15,3)"

Relates to openzipkin/zipkin-reporter-java#195
CC @adriancole


          More accurate OkHttp3 / Okio version management for OSGi deployments

2b46479

codefromthecrypt merged commit fa2ee90 into openzipkin:master

Member

codefromthecrypt commented Dec 24, 2020

thanks @reta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet