Fixed TracingKafkaClientSupplier to properly override getAdmin

[TYsewyn]

getAdminClient has been deprecated in favor of getAdmin.
Calls to getAdminClient are throwing an UnsupportedOperationException in kafka-streams version < 3.0.0, while calls to getAdmin are also throwing an UnsupportedOperationException in kafka-streams version >= 3.0.0

Fixes #1316

[jeqo]

LGTM, thanks @TYsewyn

[jeqo]

@TYsewyn could you update the license headers and push again?

[jcchavezs]

@TYsewyn I think jeqo meant to do so on the modified file only. Could you please drop the last too commits and update only the header of the modified file?

[TYsewyn]

Sure, I can do that. Can any of you fix the other license headers in the main branch?
None of the PRs are actually going to build right now, see https://github.com/openzipkin/brave/runs/4510741287?check_suite_focus=true#step:4:110

[jcchavezs]

@TYsewyn could you please open a PR with header updates for the POMs?

[jcchavezs]

@TYsewyn this PR address the license issue #1315

[jcchavezs]

@TYsewyn do you mind rebasing?

[jcchavezs]

Could we exhibit a failing test case?

[TYsewyn]

Just following up. Do we know when this is going to be merged (and eventually released)?

[jcchavezs]

Somehow this comment got through:

Quick question: will this work with both <3.0.0 and >=3.0.0?

[TYsewyn]

Yes, it should. getAdminClient was deprecated in <3.0.0, and getAdmin was added for >=3.0.0.
<3.0.0 calls getAdminClient, and >=3.0.0 calls getAdmin.

TracingKafkaClientSupplier still implements getAdminClient. This implementation calls getAdmin which returns an instance of AdminClient.

[jcchavezs]

Ideally I'd like to exhibit a test case where we use <3.0.0 and >3.0.0 (just to make sure we don't break the implementation in further changes) but I guess that can backfilled later. I will merge as it is. If you fill so, a unit test as I described would be good.

[TYsewyn]

I believe that would be quite difficult to achieve since you would need to have both versions on your classpath at the same time. Unless you create separate submodules for Kafka integration tests.

[jcchavezs]

New release is out: https://github.com/openzipkin/brave/releases/tag/5.13.6

Unless you create separate submodules for Kafka integration tests.

That sounds reasonable. Any input @jeqo?