fix: http5 parent version

[jeqo]

With the headers version reported and fixed on #1372, seems http5 module got stuck on a previous version of the parent module when merging #1274 .

This fix should unblock the main workflows that are complaining about this issue.

[JochemKuijpers]

For what it's worth, I also ran into this locally when adjusting the license headers (and blamed my inexperience with setting up this project).

I managed to get it to compile by setting the project version for httpclient5 and it's dependencies back to 5.15.1 (no snapshot). I did not include this change in my commit of course.

When attempting either 5.15.1-SNAPSHOT or 5.15.2-SNAPSHOT, Maven kept complaining about not being able to find the relevant dependency, despite it being present in the oss.sonatype.org repository. I didn't understand why..
That may be what you're running into now?

[jeqo]

@JochemKuijpers maven is not configured to use sonatype for snapshots, so in this case as the http5 parent is not aligned with the project it's failing to find it.
If you build the whole project locally, then it should be working with 5.15.2-SNAPSHOT as it's the version of the parent pom:

brave/pom.xml

Line 22 in dac1101

<version>5.15.2-SNAPSHOT</version>

[JochemKuijpers]

Interesting, I believe I tried that. But good to know for future contributions 👍

Tangential question (please forgive me for asking here, Glitter seems mostly abandoned 😅):
Do you think once this is merged and master builds are green, it would be feasible to create a new release that includes the Apache 5.2+ support? Or is there any other work that needs to happen? I'd love to contribute if that means this feature gets released sooner.

[jeqo]

Sure! I think once the build is fixed we can create a new release

[jeqo]

Thanks @jcchavezs! builds seem to be back on track (at least not failing because of wrong parent version).
Will release 5.16.0 later today.

[jeqo]

https://github.com/openzipkin/brave/releases/tag/5.16.0