Allows non-inheriting trace context #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
not-inheritable
branch
from
5874318
to
a736002
Compare
codefromthecrypt
force-pushed
the
not-inheritable
branch
2 times, most recently
from
8cf8b8d
to
70c93c4
Compare
Eventhough convenience may mean an inheriting thread local is a good choice, there are problems with this approach, such as the inability to cleanup data. This encourages use of non-inheriting thread local w/o changing the default.
codefromthecrypt
force-pushed
the
not-inheritable
branch
from
70c93c4
to
c6b1e0b
Compare
|
simplified the javadoc a bit, notably ridding the discussion about static references as the underlying problem is different tracer instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventhough convenience may mean an inheriting thread local is a good
choice, there are problems with this approach, such as the inability to
cleanup data. This encourages use of non-inheriting thread local w/o
changing the default.
fixes openzipkin-contrib/brave-opentracing#48