-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement tracing streams.filter() #901
implement tracing streams.filter() #901
Conversation
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/TracingPredicate.java
Outdated
Show resolved
Hide resolved
ccf38ce
to
14e4158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgheymans thanks! I think we are very close. I left some comments to consider filterNot
as well https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java#L79
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/TracingPredicate.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/TracingPredicate.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/main/java/brave/kafka/streams/TracingPredicate.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams/src/test/java/brave/kafka/streams/ITKafkaStreamsTracing.java
Outdated
Show resolved
Hide resolved
…s still the headers() issue.
One more thing, TracingFilterTransformer is an AbstractTracingTransformer that handles its own |
True, we need a Supplier for TracingFilterTransformer as well. |
The last commit adds the supplier and fixes the integration tests. Also somehow the error about accessing the kafka headers outside of message processing is gone now, maybe it had something to do with the FilterTransformer being wrapped .. not sure. So from my part this is good to go, let me know if you have any further comments i'd be happy to address them 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jorgheymans !!
fixes #899