Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement tracing streams.filter() #901

Merged
merged 3 commits into from
May 2, 2019

Conversation

jorgheymans
Copy link
Contributor

fixes #899

Copy link
Member

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgheymans thanks! I think we are very close. I left some comments to consider filterNot as well https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java#L79

@jorgheymans
Copy link
Contributor Author

One more thing, TracingFilterTransformer is an AbstractTracingTransformer that handles its own transform logic because it needs to tag the span. Because of this, the wrapping in TracingTransformerSupplier#get() is perhaps not needed for this case ? It adds an extra span unnecessarily IMO.

@jeqo
Copy link
Member

jeqo commented Apr 30, 2019

One more thing, TracingFilterTransformer is an AbstractTracingTransformer that handles its own transform logic because it needs to tag the span. Because of this, the wrapping in TracingTransformerSupplier#get() is perhaps not needed for this case ? It adds an extra span unnecessarily IMO.

True, we need a Supplier for TracingFilterTransformer as well.

@jorgheymans
Copy link
Contributor Author

The last commit adds the supplier and fixes the integration tests. Also somehow the error about accessing the kafka headers outside of message processing is gone now, maybe it had something to do with the FilterTransformer being wrapped .. not sure.

So from my part this is good to go, let me know if you have any further comments i'd be happy to address them 👍

Copy link
Member

@jeqo jeqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jorgheymans !!

@jeqo jeqo merged commit 3f84fa2 into openzipkin:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for filter() in KafkaStreamsTracing
2 participants