Trades unused letChildId for letId #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds letId which is a shortcut to combining tracer.scoped with setId. It pays for the additional code by removing an unused function: tracer.letChildId
Merged
mkante
approved these changes
Jan 8, 2018
|
versions will be sorted on release. |
|
we have a persistent issue in the node 4 tests which is behind the red |
|
Cool thx |
|
@pbadenski do you have time to update the http instrumentation to use letId? I think it might be less errorprone, but could be wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds letId which is a shortcut to combining tracer.scoped with
setId. It pays for the additional code by removing an unused function:
tracer.letChildId