more Android work #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekoby
requested review from
andrewpmartinez,
plorenz,
rentallect,
michaelquigley,
scareything and
dovholuknf
|
test |
dovholuknf
reviewed
Nov 14, 2019
| try { | ||
| val handlerField = | ||
| URL::class.java.getDeclaredField("handler").apply { isAccessible = true } | ||
| defaultHTTPSHandler = URL("https://google.com").let { |
There was a problem hiding this comment.
is this actually reaching out to google as some sort of test? can you document 'what' and 'why' is going on here? this seems a little odd to me
There was a problem hiding this comment.
This is just used to capture default URLStreamHandler. We don't call connect() or any other methods triggering connection, so no network communication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android we need special handling in order in intercept HTTP(S) traffic. This has to do with the way Android delegates TLS handling into native libraries.