You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice to have the OpenZiti CLI version intended to be used with the ziti-cli-functions.sh script hard-coded in the script. With this, the script can then check the CLI version ziti --version and verify it is designed to work with that version. Otherwise, notify the user that some features may not work properly.
There should also be some sort of test that checks that the version in the ziti-cli-functions.sh script matches the CLI version, if it doesn't, notify the developer running the tests that the version in the script may need to be updated. Though, not every new CLI version will cause breaking changes in the script so I wouldn't think we'd want the hard-coded version to update with every CLI version change, that might get annoying to quickstart users who get a warning when it's not necessary. Maybe there's a better way to handle this check rather than using a test 🤷 .
The text was updated successfully, but these errors were encountered:
It would be nice to have the OpenZiti CLI version intended to be used with the
ziti-cli-functions.sh
script hard-coded in the script. With this, the script can then check the CLI versionziti --version
and verify it is designed to work with that version. Otherwise, notify the user that some features may not work properly.There should also be some sort of test that checks that the version in the
ziti-cli-functions.sh
script matches the CLI version, if it doesn't, notify the developer running the tests that the version in the script may need to be updated. Though, not every new CLI version will cause breaking changes in the script so I wouldn't think we'd want the hard-coded version to update with every CLI version change, that might get annoying to quickstart users who get a warning when it's not necessary. Maybe there's a better way to handle this check rather than using a test 🤷 .The text was updated successfully, but these errors were encountered: