Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version synchronization between CLI and quickstart script #1103

Open
gberl002 opened this issue Apr 27, 2023 · 1 comment
Open

Version synchronization between CLI and quickstart script #1103

gberl002 opened this issue Apr 27, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@gberl002
Copy link
Contributor

It would be nice to have the OpenZiti CLI version intended to be used with the ziti-cli-functions.sh script hard-coded in the script. With this, the script can then check the CLI version ziti --version and verify it is designed to work with that version. Otherwise, notify the user that some features may not work properly.

There should also be some sort of test that checks that the version in the ziti-cli-functions.sh script matches the CLI version, if it doesn't, notify the developer running the tests that the version in the script may need to be updated. Though, not every new CLI version will cause breaking changes in the script so I wouldn't think we'd want the hard-coded version to update with every CLI version change, that might get annoying to quickstart users who get a warning when it's not necessary. Maybe there's a better way to handle this check rather than using a test 🤷 .

@gberl002 gberl002 added the enhancement New feature or request label Apr 27, 2023
plorenz pushed a commit that referenced this issue Sep 28, 2023
…protocol

fixes #1103 allow multiple advertise hostnames for listeners
@plorenz
Copy link
Member

plorenz commented Sep 28, 2023

Was closed when edge was merge to ziti and a commit comment referencing an edge issue now referenced this issue. Reopening.

@plorenz plorenz reopened this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants