Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getZiti should not re-download the binary #1116

Open
dovholuknf opened this issue May 22, 2023 · 1 comment
Open

getZiti should not re-download the binary #1116

dovholuknf opened this issue May 22, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dovholuknf
Copy link
Member

right now the helper script ziti-cli-functions.sh provides a getZiti function. If you invoke that function twice from bash the script does not properly detect that the lastest ziti binary has been downloaded:

$ getZiti
using default ZITI_HOME: /home/cd/.ziti/quickstart/
ZITI_BINARIES_VERSION: v0.27.9
Downloading https://github.com/openziti/ziti/releases/download/v0.27.9/ziti-linux-amd64-0.27.9.tar.gz to /home/cd/.ziti/quickstart//ziti-bin/ziti-linux-amd64-0.27.9.tar.gz
UNZIPPING /home/cd/.ziti/quickstart//ziti-bin/ziti-linux-amd64-0.27.9.tar.gz into: /home/cd/.ziti/quickstart//ziti-bin/ziti-v0.27.9
Marking executables at /home/cd/.ziti/quickstart//ziti-bin/ziti-v0.27.9 executable
cd@172.20.166.120:sg3u22: /mnt/v/temp/zssh
$ getZiti yes
ZITI_BINARIES_VERSION: v0.27.9
Using ZITI_BIN_DIR: /home/cd/.ziti/quickstart//ziti-bin/ziti-v0.27.9
Downloading https://github.com/openziti/ziti/releases/download/v0.27.9/ziti-linux-amd64-0.27.9.tar.gz to /home/cd/.ziti/quickstart//ziti-bin/ziti-bin/ziti-linux-amd64-0.27.9.tar.gz
UNZIPPING /home/cd/.ziti/quickstart//ziti-bin/ziti-bin/ziti-linux-amd64-0.27.9.tar.gz into: /home/cd/.ziti/quickstart//ziti-bin/ziti-v0.27.9
mv: cannot overwrite non-directory '/home/cd/.ziti/quickstart//ziti-bin/ziti-v0.27.9/ziti' with directory '/home/cd/.ziti/quickstart//ziti-bin/ziti-bin/ziti'

getZiti should:

  • place the binaries into the same known location each time it's run
  • notice when $ZITI_HOME or $ZITI_NETWORK is unset (notice the path downloaded: /quickstart//ziti-bin/ and the extra slash in the path
  • not download the binary if it already exists at the target location
@dovholuknf dovholuknf added enhancement New feature or request good first issue Good for newcomers labels May 22, 2023
plorenz added a commit that referenced this issue Sep 28, 2023
Convert external jwt signers to raft commands. Fixes #1116
@plorenz
Copy link
Member

plorenz commented Sep 28, 2023

Was closed when edge was merge to ziti and a commit comment referencing an edge issue now referenced this issue. Reopening.

@plorenz plorenz reopened this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants