Release 0.15.0 #122
Merged
Release 0.15.0 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpmartinez
requested review from
plorenz,
rentallect,
michaelquigley,
ekoby,
scareything,
smilindave26,
dovholuknf and
JeremyTellier
emoscardini
reviewed
Jun 16, 2020
doc/release-notes.md
Outdated
| @@ -1,6 +1,23 @@ | |||
| # Release 0.14.13 | |||
There was a problem hiding this comment.
@andrewpmartinez Release 0.15.0?
There was a problem hiding this comment.
@andrewpmartinez i have a pr to this branch out there that updates the readme to 0.15.0 as edward points out. also shouldn't the databaser snapshot stuff get put into 0.15.0?
…the usage and error from cobra in favor of ours
dovholuknf
reviewed
Jun 17, 2020
dovholuknf
reviewed
Jun 17, 2020
dovholuknf
reviewed
Jun 17, 2020
| } | ||
|
|
||
| requestMsg := channel2.NewMessage(int32(mgmt_pb.ContentType_SnapshotDbRequestType), nil) | ||
| responseMsg, err := ch.SendAndWaitWithTimeout(requestMsg, 5*time.Second) |
There was a problem hiding this comment.
i mean- 5 seconds should be enough but is there any harm in waiting longer? just in case? if the timeout hits can we cancel the request to backup somehow?
There was a problem hiding this comment.
I wouldn't worry too much about it for now. ziti-fabric will go away in the short to medium term.
dovholuknf
approved these changes
Jun 17, 2020
Nicer enroller output
…mission in development/example config.
* Add names to fabric service/routers. Add snapshot-db command
update refs and doc
plorenz
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.