Move release process to be based off of tagging instead of pushes to main #2141
Conversation
plorenz
force-pushed
the
tag-based-releases
branch
from
4b562b9
to
4d3107f
Compare
| name: release | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
Tag creates the release, marked as pre-release. Could do it the other way, but it's even more manual
There was a problem hiding this comment.
don't we want release to be a deliberate manual process?
either way is fine
There was a problem hiding this comment.
It is a deliberate manual process, it's just one done via tag, push tag, rather than through the GH UI.
RELEASING.md
Outdated
| (`isLatest: true`). | ||
|
|
||
| 1. After an arbitrary burn-in period, unmark "prerelease" in GitHub Releases (`isPrerelease: false`) to stop | ||
| discouraging users from consuming the now-stable release. This will automatically promote and advertise the downstreams. |
There was a problem hiding this comment.
is this supposed to be non-stable?
stop discouraging reads like double negative, I had to think what it means
There was a problem hiding this comment.
Let's drop the confusing part. The intent is to emphasize that setting isPrerelease: false triggers promoting downstreams, not isLatest: true.
to stop discouraging users from consuming the now-stable release
plorenz
force-pushed
the
tag-based-releases
branch
from
addd340
to
a731c28
Compare
No description provided.