allow init container on the simplified docker compose #743
Conversation
| if [[ "$EXTERNAL_DNS" != "" ]]; then pki_allow_list="$pki_allow_list,$EXTERNAL_DNS"; fi | ||
| pki_client_server "${pki_allow_list}" "${ZITI_CONTROLLER_INTERMEDIATE_NAME}" "${ZITI_CONTROLLER_IP_OVERRIDE-}" "${ZITI_CONTROLLER_HOSTNAME}" | ||
| pki_client_server "${ZITI_EDGE_CONTROLLER_HOSTNAME},localhost,127.0.0.1" "${ZITI_EDGE_CONTROLLER_INTERMEDIATE_NAME}" "${ZITI_EDGE_CONTROLLER_IP_OVERRIDE-}" "${ZITI_EDGE_CONTROLLER_HOSTNAME}" | ||
| pki_allow_list_dns="${ZITI_CONTROLLER_HOSTNAME},localhost,$(hostname)" |
There was a problem hiding this comment.
ZITI_CONTROLLER_HOSTNAME is commented out in .env. Do you mean to if check this here?
There was a problem hiding this comment.
not for this one. i just renamed pki_allow_list to pki_allow_list_dns where it was already pki_allow_list="${ZITI_CONTROLLER_HOSTNAME},localhost,127.0.0.1" . I just kept this one the same as it was before. I did change from the IP 127.0.0.1 to $(hostname) though.
| pki_allow_list_ip="127.0.0.1" | ||
| if [[ "${ZITI_EDGE_CONTROLLER_IP_OVERRIDE}" != "" ]]; then pki_allow_list_ip="${pki_allow_list_ip},${ZITI_EDGE_CONTROLLER_IP_OVERRIDE}"; fi | ||
| if [[ "${EXTERNAL_IP}" != "" ]]; then pki_allow_list_ip="${pki_allow_list_ip},${EXTERNAL_IP}"; fi | ||
|
|
There was a problem hiding this comment.
Did you cover all the possible variables (compared to .env it looks like a couple are missing if that was your intent)
There was a problem hiding this comment.
Covered the ones I wanted to add at this time. I was hoping Geoff would be able to check to see if anything I left off is major. The variable overriding grew up organically and needs to be overhauled. I'm hoping when we have tests we'll be able to refactor this and feel good we're coving them all. @gberl002 - can you check this for me too please?
closes #742 . Also adds example how to override the env vars to produce a docker env with a totally overridden name