Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix GINKGO_OPTS #3337

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
Splits the Make variable GINKGO_OPTS into an internal and external variables: GINKGO_OPTS (ext) E2E_GINKGO_OPTS (int).

Motivation for the change:
Setting GINKGO_OPTS in a different Makefile and calling this Makefile does not currently have the desired effect.
With this change build jobs have more options to affect the ginkgo run (e.g. generate test reports, etc.)

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@bentito
Copy link
Contributor

bentito commented Jul 2, 2024

/approve

@perdasilva perdasilva merged commit 8615a10 into operator-framework:master Jul 2, 2024
12 checks passed
@perdasilva perdasilva deleted the fix/gikgopts branch July 2, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants