Makefile,version,cmd/operator-sdk/version: add git compile-time variables #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for git version and commit
joelanford
requested review from
shawn-hurley,
AlexNPavel,
lilic,
hasbro17,
theishshah and
estroz
openshift-ci-robot
added
the
size/S
|
New changes are detected. LGTM label has been removed. |
openshift-ci-robot
added
size/M
lilic
approved these changes
May 17, 2019
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
May 21, 2019
…bles (operator-framework#1431) * Makefile,version,cmd/operator-sdk/version: add compile-time variables for git version and commit * release.sh: new format for Version in version.go
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
May 21, 2019
…bles (operator-framework#1431) * Makefile,version,cmd/operator-sdk/version: add compile-time variables for git version and commit * release.sh: new format for Version in version.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
version.GitVersionandversion.GitCommitoperator-sdk versioncommand to print themMotivation for the change:
Many users seem to be using non-release versions of
operator-sdk, so lots of issues typically only report the version as something likev0.7.0+git.To make it easier to troubleshoot issues, it would be nice to have the
operator-sdk versioncommand print the git version and commit strings.