Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: release v0.8.0 #1445

Merged
merged 1 commit into from
May 17, 2019
Merged

Conversation

AlexNPavel
Copy link
Contributor

Description of the change: Update to v0.8.0

Motivation for the change: Release v0.8.0

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 17, 2019
@@ -109,6 +109,7 @@ replace (
github.com/coreos/prometheus-operator => github.com/coreos/prometheus-operator v0.29.0
k8s.io/code-generator => k8s.io/code-generator v0.0.0-20181117043124-c2090bec4d9b
k8s.io/kube-openapi => k8s.io/kube-openapi v0.0.0-20180711000925-0cf8f7e6ed1d
github.com/operator-framework/operator-sdk => github.com/operator-framework/operator-sdk v0.8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the version in the require section or keep this as a separate replace?

I read this, and I still don't think I know which is the correct way to do this. Thoughts?

/cc @estroz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed what we have in our release doc. I feel like the replace statement makes sense for this situation, but I don't know much about go mod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace pins a module version absolutely. This is similar to a Gopkg.toml override. See the last point in the replace section of this doc.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexNPavel AlexNPavel merged commit 78c4724 into operator-framework:master May 17, 2019
@AlexNPavel AlexNPavel deleted the v0.8.0-release branch May 17, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants