Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbundle resolveConflict into resolveConflictBySelecting and resolveConflictWithNewChange #149

Closed
samuelstroschein opened this issue Aug 28, 2024 — with Linear · 0 comments
Assignees

Comments

Copy link
Member

samuelstroschein commented Aug 28, 2024

Context

Resolve conflict does two jobs at once which leads to confusion and a bloated implementation. See opral/monorepo#3073 (comment)

Proposal

Unbundle the two different purposes into dedicated functions.

await resolveConflictBySelecting({ lix, conflict, select: change.id })
await resolveConflictWithNewChange({ lix, conflict, change: newChange })

The function names can be improved later. If we figure out that selecting fulfills the majority of use cases, we can alias resolveConflictBySelecting with resolveConflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant