refactor: remove bundle.alias

inlang/source-code/ide-extension/src/commands/machineTranslate.test.ts

@@ -56,7 +56,6 @@ vi.mock("../utilities/state", () => ({
 
 vi.mock("@inlang/sdk2", () => ({
 	selectBundleNested: vi.fn(),
-	bundleIdOrAliasIs: vi.fn(),
 }))
 
 const mockBundle: BundleNested = {

inlang/source-code/ide-extension/src/utilities/helper.ts

@@ -1,12 +1,15 @@
-import { bundleIdOrAliasIs, selectBundleNested, type IdeExtensionConfig } from "@inlang/sdk2"
+import { selectBundleNested, type IdeExtensionConfig } from "@inlang/sdk2"
 import { state } from "./state.js"
 
 export const getExtensionApi = async (): Promise<IdeExtensionConfig | undefined> =>
 	(await state().project.plugins.get()).find((plugin) => plugin?.meta?.["app.inlang.ideExtension"])
 		?.meta?.["app.inlang.ideExtension"] as IdeExtensionConfig | undefined
 
+/**
+ * Not needed anymore but left in to reduce refactoring https://github.com/opral/monorepo/pull/3137
+ */
 export const getSelectedBundleByBundleIdOrAlias = async (bundleIdOrAlias: string) => {
 	return await selectBundleNested(state().project.db)
-		.where(bundleIdOrAliasIs(bundleIdOrAlias))
+		.where("bundle.id", "=", bundleIdOrAlias)
 		.executeTakeFirst()
 }

inlang/source-code/ide-extension/src/utilities/lint-rules/lintRules.test.ts

@@ -27,7 +27,6 @@ vi.mock("../state.js", () => ({
 
 vi.mock("@inlang/sdk2", () => ({
 	selectBundleNested: vi.fn(),
-	bundleIdOrAliasIs: vi.fn(),
 }))
 
 vi.mock("vscode", () => ({

inlang/source-code/ide-extension/src/utilities/messages/messages.test.ts

@@ -64,7 +64,6 @@ describe("Message Webview Provider Tests", () => {
 		const html = await createMessageHtml({
 			bundle: {
 				id: "message-id",
-				alias: { aliasKey: "aliasValue" },
 				messages: [
 					{
 						id: "message-id",
@@ -91,7 +90,6 @@ describe("Message Webview Provider Tests", () => {
 
 		// Validating that the created HTML contains the expected content
 		expect(html).toContain("message-id")
-		expect(html).toContain("aliasValue")
 		expect(html).toContain("Hello")
 	})
 
@@ -113,7 +111,6 @@ describe("Message Webview Provider Tests", () => {
 		const html = await createMessageHtml({
 			bundle: {
 				id: "message-id",
-				alias: { aliasKey: "aliasValue" },
 				messages: [],
 			},
 			isHighlighted: false,
@@ -146,7 +143,6 @@ describe("Message Webview Provider Tests", () => {
 		const html = await getTranslationsTableHtml({
 			bundle: {
 				id: "message-id",
-				alias: {},
 				messages: [
 					{
 						id: "message-id",
@@ -197,7 +193,6 @@ describe("Message Webview Provider Tests", () => {
 		const html = await getTranslationsTableHtml({
 			bundle: {
 				id: "message-id",
-				alias: {},
 				messages: [], // No messages for any locale
 			},
 			workspaceFolder: {

inlang/source-code/ide-extension/src/utilities/messages/messages.ts

@@ -6,15 +6,12 @@ import { escapeHtml } from "../utils.js"
 // TODO: Uncomment when bundle subscribe is implemented
 // import { throttle } from "throttle-debounce"
 import {
-	type ProjectSettings,
 	selectBundleNested,
-	type Bundle,
 	type BundleNested,
 	type IdeExtensionConfig,
 	type InlangProject,
 	pollQuery,
 } from "@inlang/sdk2"
-import { getSelectedBundleByBundleIdOrAlias } from "../helper.js"
 
 export function createMessageWebviewProvider(args: {
 	context: vscode.ExtensionContext
@@ -88,7 +85,7 @@ export function createMessageWebviewProvider(args: {
 			matchedBundles.map(async (bundle) => {
 				// @ts-ignore TODO: Introduce deprecation message for messageId
 				bundle.bundleId = bundle.bundleId || bundle.messageId
-				const bundleData = await getSelectedBundleByBundleIdOrAlias(bundle.bundleId)
+				const bundleData = await selectBundleNested(state().project.db).where("id", "=", bundle.bundleId).executeTakeFirst()
 				return bundleData
 			})
 		)
@@ -236,31 +233,6 @@ export async function createMessageHtml(args: {
 	isHighlighted: boolean
 	workspaceFolder: vscode.WorkspaceFolder
 }): Promise<string> {
-	// Function to check if the record has any keys
-	const hasAliases = (aliases: Bundle["alias"]): boolean => {
-		return Object.keys(aliases).length > 0
-	}
-
-	const isExperimentalAliasesEnabled = ((await state().project.settings.get()) as ProjectSettings)
-		.experimental?.aliases
-
-	const aliasHtml =
-		isExperimentalAliasesEnabled && hasAliases(args.bundle.alias)
-			? `<div class="aliases" title="Alias">
-                <span><strong>@</strong></span>
-                <div>
-                ${Object.entries(args.bundle.alias)
-									.map(
-										([key, value]) =>
-											`<span data-alias="${escapeHtml(value)}"><i>${escapeHtml(key)}</i>: ${escapeHtml(
-												value
-											)}</span>`
-									)
-									.join("")}
-                </div>
-            </div>`
-			: ""
-
 	const translationsTableHtml = await getTranslationsTableHtml({
 		bundle: args.bundle,
 		workspaceFolder: args.workspaceFolder,
@@ -295,7 +267,6 @@ export async function createMessageHtml(args: {
         </div>
         <div class="content" style="display: none;">
             ${translationsTableHtml}
-            ${aliasHtml}
         </div>
     </div>
     `

inlang/source-code/ide-extension/src/utilities/project/project.ts

@@ -5,7 +5,7 @@ import { telemetry } from "../../services/telemetry/index.js"
 import { setState, state } from "../state.js"
 import * as Sherlock from "@inlang/recommend-sherlock"
 import { transpileToCjs } from "../import/transpileToCjs.js"
-import * as fs from "node:fs/promises"
+import * as fs from "node:fs"
 import type { FileSystem } from "../fs/createFileSystemMapper.js"
 import path from "node:path"
 

inlang/source-code/sdk2/src/query-utilities/index.ts

@@ -2,5 +2,4 @@ export { selectBundleNested } from "./selectBundleNested.js";
 export { insertBundleNested } from "./insertBundleNested.js";
 export { updateBundleNested } from "./updateBundleNested.js";
 export { upsertBundleNested } from "./upsertBundleNested.js";
-export { bundleIdOrAliasIs } from "./bundleIdOrAliasIs.js";
 export { pollQuery } from "./pollQuery.js";