Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add message when first pattern added to a language #2893

Merged
merged 1 commit into from
Jun 6, 2024
+46 −26
Merged

feat: add message when first pattern added to a language #2893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions inlang/source-code/message-bundle-component/src/stories/inlang-message-bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ export default class InlangMessageBundle extends LitElement {
}
}

_addMessage = (message: Message) => {
if (this.messageBundle) {
this.messageBundle.messages.push(message)
this.requestUpdate()
}
}

override async firstUpdated() {
await this.updateComplete
// override primitive colors to match the design system
Expand Down Expand Up @@ -146,13 +153,17 @@ export default class InlangMessageBundle extends LitElement {
.message=${message}
.inputs=${this._fakeInputs()}
.triggerSave=${this._triggerSave}
.addMessage=${this._addMessage}
.languageTag=${languageTag}
.lintReports=${messageLintReports}
></inlang-variant>`
)
: html`<inlang-variant
.message=${message}
.inputs=${this._fakeInputs()}
.triggerSave=${this._triggerSave}
.addMessage=${this._addMessage}
.languageTag=${languageTag}
.lintReports=${messageLintReports}
></inlang-variant>`}
</div>
Expand Down
61 changes: 35 additions & 26 deletions inlang/source-code/message-bundle-component/src/stories/inlang-variant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Variant, Message } from "@inlang/sdk/v2"
import { type Variant, type Message, createMessage, type LanguageTag } from "@inlang/sdk/v2"
import { LitElement, css, html } from "lit"
import { customElement, property, state } from "lit/decorators.js"
import upsertVariant from "../helper/crud/variant/upsert.js"
Expand Down Expand Up @@ -89,6 +89,9 @@ export default class InlangVariant extends LitElement {
@property()
message: Message | undefined

@property()
languageTag: LanguageTag | undefined

@property()
variant: Variant | undefined

Expand All @@ -98,12 +101,41 @@ export default class InlangVariant extends LitElement {
@property()
lintReports: MessageLintReport[] | undefined

@property()
addMessage: (newMessage: Message) => void = () => {}

@property()
triggerSave: () => void = () => {}

@state()
private _pattern: string | undefined = undefined

_save = () => {
if (this.message && this.variant && this._pattern) {
// upsert variant
upsertVariant({
message: this.message,
variant: {
match: this.variant.match,
pattern: [
{
type: "text",
value: this._pattern,
},
],
},
})
this.triggerSave()
} else {
// new message
if (this.languageTag && this._pattern) {
//TODO: only text pattern supported
this.addMessage(createMessage({ locale: this.languageTag, text: this._pattern }))
this.triggerSave()
}
}
}

private get _selectors(): string[] | undefined {
// @ts-ignore - just for prototyping
return this.message ? this.message.selectors.map((selector) => selector.arg.name) : undefined
Expand All @@ -118,6 +150,7 @@ export default class InlangVariant extends LitElement {
}

override render() {
//console.log(this.message)
return html`<div class="variant">
${this.variant && this._matches
? this._matches.map((match) => html`<div class="match">${match}</div>`)
Expand All @@ -142,31 +175,7 @@ export default class InlangVariant extends LitElement {
}}
></sl-input>
<div class="actions">
<sl-button
size="small"
@click=${() => {
if (this.message && this.variant && this._pattern) {
// upsert variant
upsertVariant({
message: this.message,
variant: {
match: this.variant.match,
pattern: [
{
type: "text",
value: this._pattern,
},
],
},
})
this.triggerSave()
} else {
// new message
console.info("TODO create new message")
}
}}
>Save</sl-button
>
<sl-button size="small" @click=${() => this._save()}>Save</sl-button>
${this.message?.selectors && this.message.selectors.length === 0
? html`<inlang-selector-configurator .inputs=${this.inputs} .message=${this.message}>
<sl-tooltip content="Add Selector to message"
Expand Down
Loading