Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example code title for Pages router #3021

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Conversation

Unsleeping
Copy link
Contributor

This pull request addresses an issue in the documentation where Pages Router examples were incorrectly labeled with the App Router title, "App Router Example Source Code."

The title have been updated to accurately reflect the respective examples:

The App Router example remains titled "App Router Example Source Code."
The Pages Router example is now correctly titled "Pages Router Example Source Code."

This change ensures clarity and helps developers easily distinguish between the two examples.

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: c213ffc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@LorisSigrist
Copy link
Collaborator

Hi @Unsleeping, thanks for spotting the typo

You need to sign the Contributor Agreement before I can merge it. Please post a reply in this PR containing the following text

I have read the CLA Document and I hereby sign the CLA

@Unsleeping
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 17, 2024
@Unsleeping
Copy link
Contributor Author

Hi @Unsleeping, thanks for spotting the typo

You need to sign the Contributor Agreement before I can merge it. Please post a reply in this PR containing the following text

I have read the CLA Document and I hereby sign the CLA

done

@LorisSigrist LorisSigrist merged commit 5255050 into opral:main Aug 17, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants