Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: providePlugin api #3041

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

samuelstroschein
Copy link
Member

Changes

Lix can be opened with providePlugin: [myplugin].

const mockPlugin: LixPlugin = {
  key: "mock-plugin",
  glob: "*",
  diff: {},
}
const lix = await openLixInMemory({ blob: await newLixFile(), providePlugin: [mockPlugin] })

Why

It avoids separating the inlang plugin code from the app (SDK) code.

  • no dual packaging
  • no bundling needed

Additional information

I have concerns about the portability of the change. Any inlang file must now be loaded through the inlang SDK for lix to work. The plugin is not saved in lix. We can revisit this decision but for now we can iterate faster.

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: af5254e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lix/packages/sdk/src/open/openLix.ts Outdated Show resolved Hide resolved
@samuelstroschein samuelstroschein merged commit 648e8e2 into samuel/lix-integration Aug 5, 2024
2 checks passed
@samuelstroschein samuelstroschein deleted the lix-api-provide-plugin branch August 5, 2024 21:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants