refactor: bundle component #3080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bundle - message - variant - pattern-editor - bundle-action - add-selector
|
- remove all crud helpers - add comments where needed - test the components in storybook They are good enough to proceed to fink2
…jacobsen/inlmc-141-refactoring-no-easy-way-to-use-subcomponents-independently
NilsJacobsen
deleted the
nilsjacobsen/inlmc-141-refactoring-no-easy-way-to-use-subcomponents-independently
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gonna leave this a draft until my todos are finished.
Goal
Unbundle the bundle component -> all the sub components should be used in a slotted way so we can nest our own stuff flexibly into it. (For example: show lix blame in variant)
Todos