-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Import messages from local files #3099
Add: Import messages from local files #3099
Conversation
For backwards compatibility reasons are the path patterns resolved from the project directory, not the settings file.
The plugin key can be derived from the plugin that provides the function.
|
@samuelstroschein thank you for making this available in the sdk:) Probably only the video but it feels very laggy now, have to test myself tomorrow. But it is that laggy in real-time as in the video, we can't release it to our user without performance improvements. Kinda related to this issue: I'm wondering why we haven't thought about the absolute path resolving before — and therefore wondering if there are any other concepts we might have missed from the previous implementation of sdk v1. Is sdk v2 passing all the test for sdk v1? This would be highly beneficial to have more confidence on backwards compatibility. @martin-lysk what's your take on this? |
Because apps that don't use
Just test sherlock with existing projects. bugfixes will quickly be accepted. web apps don't need anything from SDK v1. hence, we haven't copied the tests over. |
Closes opral/inlang-sdk#174. Messages can now be loaded in Sherlock (cc @felixhaeberle)
CleanShot.2024-09-07.at.13.25.51.mp4
Changes
plugin.loadMessages
receives a mapped fs that turns relative paths into absolute paths to maintain backward compatibilityFollow up todos
plugin.saveMessages
andplugin.toBeImportedFiles()
after loadProjectFromDirectory file sync, import & export sync inlang-sdk#159 is merged