Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Import messages from local files #3099

Conversation

samuelstroschein
Copy link
Member

Closes opral/inlang-sdk#174. Messages can now be loaded in Sherlock (cc @felixhaeberle)

CleanShot.2024-09-07.at.13.25.51.mp4

Changes

  • plugin.loadMessages receives a mapped fs that turns relative paths into absolute paths to maintain backward compatibility
  • sherlock subscribes to bundles to display messages

Follow up todos

Copy link

changeset-bot bot commented Sep 7, 2024

⚠️ No Changeset found

Latest commit: a59f6ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein samuelstroschein marked this pull request as ready for review September 7, 2024 17:45
@samuelstroschein samuelstroschein merged commit 02458ff into lix-integration Sep 7, 2024
2 of 4 checks passed
@samuelstroschein samuelstroschein deleted the mesdk-217-fix-cwd-bug-with-plugin-imports-by-making-paths-absolute branch September 7, 2024 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
@felixhaeberle
Copy link
Contributor

@samuelstroschein thank you for making this available in the sdk:)

Probably only the video but it feels very laggy now, have to test myself tomorrow. But it is that laggy in real-time as in the video, we can't release it to our user without performance improvements.


Kinda related to this issue: I'm wondering why we haven't thought about the absolute path resolving before — and therefore wondering if there are any other concepts we might have missed from the previous implementation of sdk v1.

Is sdk v2 passing all the test for sdk v1?

This would be highly beneficial to have more confidence on backwards compatibility. @martin-lysk what's your take on this?

@samuelstroschein
Copy link
Member Author

samuelstroschein commented Sep 8, 2024

Kinda related to this issue: I'm wondering why we haven't thought about the absolute path resolving before

Because apps that don't use loadProjectFromDirectory don't use it.

and therefore wondering if there are any other concepts we might have missed from the previous implementation of sdk v1.

Just test sherlock with existing projects. bugfixes will quickly be accepted. web apps don't need anything from SDK v1. hence, we haven't copied the tests over.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants