Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jsonb instead of text for jsons columns #3103

Conversation

samuelstroschein
Copy link
Member

Closes opral/inlang-sdk#132.

The result is a working jsonb plugin, but it's fragile. Given that the inlang database schema does not leverage any other BLOB type, the plugin naively interprets every BLOB as json binary. Avoiding the heuristics by specifying the column that are JSONB didn't work. See the thread of frustrations opral/inlang-sdk#132.

Changes

  • uses jsonb (BLOB) instead of TEXT for json columns
  • removes several json stringify calls throughout the codebase

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 07a0701

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein samuelstroschein merged commit face759 into lix-integration Sep 10, 2024
2 checks passed
@samuelstroschein samuelstroschein deleted the mesdk-173-jsonb-instead-of-text-for-json-value branch September 10, 2024 00:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant