Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify match type #3142

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

samuelstroschein
Copy link
Member

@samuelstroschein samuelstroschein commented Sep 23, 2024

Simplifies the match type

  • key instead of name for increased generalizability and alignment with message format 2.0
  • type literal-match | catchall-match to get rid of redundant match type
  • gets rid of match.value.value
const variant = {
  matches: [
    { "key": "username", "type": "literal-match", "value": "samuel" },
    { "key": "platform", "type": "catchall-match" },
  ]
}

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 25df914

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein samuelstroschein merged commit ced0a89 into lix-integration Sep 23, 2024
2 of 4 checks passed
@samuelstroschein samuelstroschein deleted the simplify-mesdk-248 branch September 23, 2024 21:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant