multi parent relationship for changes #3180
Conversation
|
| }, | ||
| { | ||
| }), | ||
| expect.objectContaining({ |
There was a problem hiding this comment.
I updated the tests to expect.objectContaining to reduce the refactor effort in the future.
| FOREIGN KEY(parent_id) REFERENCES change(id), | ||
| FOREIGN KEY(child_id) REFERENCES change(id), | ||
| -- Prevent self referencing edges | ||
| CHECK (parent_id != child_id) |
There was a problem hiding this comment.
I didn't know CHECK before. Very cool. SQLite now verifies that edges are not self-referencing. A unit test has been written as well.
There was a problem hiding this comment.
I recall we used this to validate the id of the entity type. So if you try to insert an change id (here postfixed with the c) "415f1f62-2017-4761-9ece-519c1e5e45e3-c" into a snapshot you can fail early
| const parent = await lix.db | ||
| .selectFrom("change") | ||
| .innerJoin("snapshot", "snapshot.id", "change.snapshot_id") | ||
| .selectAll("change") | ||
| .select("snapshot.value") | ||
| .where("change.id", "=", change.parent_id) | ||
| .executeTakeFirstOrThrow(); | ||
|
|
||
| const { rowIndex, columnIndex } = parent.value as unknown as Cell; | ||
| (parsed.data as any)[rowIndex][columnIndex] = ""; | ||
| // if the row is empty after deleting the cell, remove it |
There was a problem hiding this comment.
Querying the snapshot is not needed anymore if the entity_id exists on the change itself 😎
| // TODO https://github.com/opral/lix-sdk/issues/105 | ||
| // .where(isInSimulatedCurrentBranch) |
There was a problem hiding this comment.
One of the TODOS that should be tackled after the branch milestone.
- branching will influence the logic
- working on this now is a waste of time
| if (parentEdges.length > 1) { | ||
| // https://github.com/opral/inlang-sdk/issues/134 | ||
| throw new Error( | ||
| "Unimplemented. Multiple parents not supported until the branch feature exists.", | ||
| ); | ||
| } |
There was a problem hiding this comment.
One of the TODOS that should be tackled after the branch milestone.
branching will influence the logic
working on this now is a waste of time
…1-multi-parent-relationship-for-changes
| FOREIGN KEY(parent_id) REFERENCES change(id), | ||
| FOREIGN KEY(child_id) REFERENCES change(id), | ||
| -- Prevent self referencing edges | ||
| CHECK (parent_id != child_id) |
There was a problem hiding this comment.
I recall we used this to validate the id of the entity type. So if you try to insert an change id (here postfixed with the c) "415f1f62-2017-4761-9ece-519c1e5e45e3-c" into a snapshot you can fail early
samuelstroschein
deleted the
lixdk-191-multi-parent-relationship-for-changes
branch
Closes opral/lix-sdk#98
Changes
change_edgestable to model multi parent relationshipsAdditional information