Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use test matrix for utility function #743

Closed
wants to merge 2 commits into from

Conversation

samuelstroschein
Copy link
Member

@samuelstroschein samuelstroschein commented May 12, 2023

Problem

The utility functions are only tested on createMemoryFs leading to discrepancies and bugs when node fs (CLI) or memfs (editor) is used.

Proposal

Test utility functions on all filesystem implementations.

Blocked by

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

⚠️ No Changeset found

Latest commit: 3dba1e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein
Copy link
Member Author

@araknast can you take this one over?

It would be good if I can focus on #452.

@araknast araknast self-assigned this May 16, 2023
@araknast
Copy link
Contributor

Sure that's fine, I'll see what I can do this week.

@samuelstroschein samuelstroschein removed their assignment May 16, 2023
@samuelstroschein
Copy link
Member Author

@araknast what's the status?

@araknast
Copy link
Contributor

@samuelstroschein At the moment speeding up cloning has higher priority since #744 has been closed and there don't seem to be any significant discrepancies causing issues in the editor at the moment. I can bump this up on my priorities list if you want, however.

@samuelstroschein
Copy link
Member Author

Closing as "Likely has no priority because hasn't been worked on in a month".

@jannesblobel jannesblobel deleted the use-test-matrix-for-filesystems branch June 27, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: lix Related to source-code/git-sdk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants