-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove version constraint of setuptools
#3231
Remove version constraint of setuptools
#3231
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 146 146
Lines 12011 12011
=======================================
Hits 10992 10992
Misses 1019 1019 Continue to review full report at Codecov.
|
Nice. Curious but do you know in what sense the previous failure was fixed with this recent release? I first though that we'd have to wait for mpi4py. |
The previous failure was due to undefined |
@HideakiImamura Could you review this PR? This PR will revert the change of your PR #3207. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the references. So it was addressed by setuptools
as well, meaning it'll also work with older versions of mpi4py
and not just the upcoming one with the fix. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
setuptools
60.5.0 has been released, https://github.com/pypa/setuptools/releases/tag/v60.5.0.Description of the changes
Undo the version constraints introduced by #3207