Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version constraint of setuptools #3231

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Jan 15, 2022

Motivation

setuptools 60.5.0 has been released, https://github.com/pypa/setuptools/releases/tag/v60.5.0.

Description of the changes

Undo the version constraints introduced by #3207

@nzw0301 nzw0301 added the installation Installation and dependency. label Jan 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3231 (4cbb391) into master (acdf4b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3231   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         146      146           
  Lines       12011    12011           
=======================================
  Hits        10992    10992           
  Misses       1019     1019           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acdf4b7...4cbb391. Read the comment docs.

@hvy
Copy link
Member

hvy commented Jan 17, 2022

Nice. Curious but do you know in what sense the previous failure was fixed with this recent release? I first though that we'd have to wait for mpi4py.

@hvy hvy self-assigned this Jan 17, 2022
@nzw0301
Copy link
Member Author

nzw0301 commented Jan 17, 2022

The previous failure was due to undefined get_versions in setuptools for cygwin, mpi4py/mpi4py#157. New setutools restores get_versions attrubute by this PR. pypa/setuptools#2969 (comment) might be a relevant comment.

@toshihikoyanase
Copy link
Member

@HideakiImamura Could you review this PR? This PR will revert the change of your PR #3207.

Copy link
Member

@hvy hvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the references. So it was addressed by setuptools as well, meaning it'll also work with older versions of mpi4py and not just the upcoming one with the fix. LGTM!

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HideakiImamura HideakiImamura merged commit 4e2ecba into optuna:master Jan 20, 2022
@HideakiImamura HideakiImamura added this to the v3.0.0-a1 milestone Jan 20, 2022
@nzw0301 nzw0301 deleted the remove-setuptools-constraint branch January 20, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation and dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants