-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: Use the default osx image. #76
Conversation
XCode 7.3 (based on macOS 10.11) is out of support, and cannot complete tests because the `brew upgrade` step has so many packages to build. Use the default image instead, which is currently macOS 10.13 and Xcode 9.4.1. This seems to resolve the recent travis test failures on macOS.
Note that the linux 2.7 python job has started failing in the meantime, so tests still won't be green with this commit. I suspect that can be fixed by removing coverage from that job as was done for the jython job, if that's a reasonable approach? |
Assume we have a more recent version (3 or later) of pytest which can be invoked as such. Also remove the report generation switches. The codecov.io docs don't suggest this, so I don't think it's necessary for upload to the site. There's no point generating the reports in ci if they're not uploaded anywhere.
The default pytest included in the travis 2.7 package (3.3.0) is too old for the pytest_cov package we install. Use pip to upgrade it before running tests. Resolves the build failure with python 2.7 on linux.
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
- Coverage 87.24% 87.14% -0.1%
=========================================
Files 26 27 +1
Lines 980 988 +8
=========================================
+ Hits 855 861 +6
- Misses 125 127 +2
Continue to review full report at Codecov.
|
9982fb3
to
bb30753
Compare
Adding Python 3.7 on Linux turned out to be a bridge too far, but the additional commit have all tests passing again. @jayanthjaiswal, @raquel-ucl what do you think? |
@rillian Great work! Thanks. Removing coverage won't hurt much. |
Thanks @rillian! |
Thanks for reviewing! I don't have commit access. Could someone please push the merge button so we can make the badge green? :) |
There you go! |
danke! |
XCode 7.3 (based on macOS 10.11) is out of support, and cannot
complete tests because the
brew upgrade
step has so manypackages to build. Use the default image instead, which is
currently macOS 10.13 and Xcode 9.4.1.
This seems to resolve the recent travis test failures on macOS.