Add a timezone as region option #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving issue #79, this branch declares an extended io.r2dbc.spi.Option to configure JDBC's timezone as region property.
By setting the property to "false", Oracle R2DBC can connect to an Oracle Database that doesn't recognize the timezone of the JVM.
I'm trying something new in the README here. I'm documenting the property, but I'm marking it as (For inclusion in the next release). The idea is that I want to document things when they are still fresh in my mind. But I also don't want to confuse programmers who might read the doc and think the option exists in the current release. I hope this works...