Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF CURSOR Support #94

Merged
merged 9 commits into from
Oct 17, 2022
Prev Previous commit
Next Next commit
Improving JavaDocs
  • Loading branch information
Michael-A-McMahon committed Oct 10, 2022
commit b9a69d11d458be11ade3737ae67c413040c988d1
2 changes: 1 addition & 1 deletion src/main/java/oracle/r2dbc/OracleR2dbcTypes.java
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ private OracleR2dbcTypes() {}
new TypeImpl(LocalDateTime.class, "TIMESTAMP WITH LOCAL TIME ZONE");

/**
* A cursor that is output by a procedural call.
* A cursor that is returned by a procedural call.
*/
public static final Type REF_CURSOR =
new TypeImpl(Result.class, "SYS_REFCURSOR");
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/oracle/r2dbc/impl/DependentCounter.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
* </p><p>
* This class offers a solution for tracking the consumption of
* {@link io.r2dbc.spi.Result} objects that depend on a JDBC statement to remain
* open until each result is consumed. Further explain can be found in the
* open until each result is consumed. Further explanations can be found in the
* JavaDocs of {@link OracleStatementImpl} and {@link OracleResultImpl}.
* </p>
*/
Expand Down Expand Up @@ -70,12 +70,13 @@ void increment() {
* subscribe to be safe.
* </p>
* @return A publisher that closes the depended upon resource after no
* dependents remain.
* dependents remain. Not null.
*/
Publisher<Void> decrement() {
return Mono.defer(() ->
count.decrementAndGet() == 0
? Mono.from(closePublisher)
: Mono.empty());
}

}