Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

122 xrsound ci build #123

Merged
merged 7 commits into from
Aug 30, 2021
Merged

122 xrsound ci build #123

merged 7 commits into from
Aug 30, 2021

Conversation

mschweiger
Copy link
Collaborator

Include XRSound build in CI build runs

  • Download irrKlang package
  • Cache package on CI server

@dbeachy1
Copy link
Member

Nice work on this @mschweiger ! 👍

@mschweiger
Copy link
Collaborator Author

Thanks! Unfortunately it doesn't seem to work. XRSound is still not included in the build. I am investigating, but if anybody has an idea what the problem is, please let me know.

@mschweiger
Copy link
Collaborator Author

Everything seems to work now. I checked that

  • The CI build triggers a failure if XRSound fails to build.
  • The cache is successfully hit, avoiding repeated downloads of the irrKlang libraries.

The cache remains valid for a limited time (7 days). If no cache hit occurs during this period, the cache is deleted, next time a new download is performed. So in the worst case, there would be a download once a week, but in practice much less frequently. That shouldn't put any undue load on the irrKlang download server.
@dbeachy1 : If you are happy, I'll merge the branch.

@dbeachy1
Copy link
Member

Great work, @mschweiger ! Looks good to me. 👍

@mschweiger mschweiger merged commit e96d45f into main Aug 30, 2021
@mschweiger mschweiger deleted the 122-xrsound_ci_build branch August 30, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants