-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging-enabled container group (wip) #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add some documentation in relevant README describing what the purpose of workspace is.
InferenceSystem/deploy-aci.yaml
Outdated
restartPolicy: Always | ||
diagnostics: | ||
logAnalytics: | ||
workspaceId: 8a090d5a-065e-4659-bc0b-7e6ecc7597a2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't put ID and key as part of repo. These are considered secrets and should only have placeholders in commit.
InferenceSystem/deploy-aci.yaml
Outdated
requests: | ||
cpu: 1.0 | ||
memoryInGB: 3 | ||
- name: inference-logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe creating an additional container in the group is necessary. This is a sample application for the example.
InferenceSystem/deploy-aci.yaml
Outdated
requests: | ||
cpu: 1.0 | ||
memoryInGB: 1.5 | ||
osType: Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these configurations are already specified elsewhere in the file. Please don't duplicate them.
Closed as no longer relevant. |
No description provided.