Rename the filtering menu to exclusion/inclusion #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah it is much better naming and much more explanatory but I think it would be better if it was include instead if inclusion and exclude instead of exclusion. Can you change it? |
|
Definitely looks better as a verb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the naming scheme in the recently extended filtering process from blacklist/whitelist to exclusion/inclusion.
Beside blacklist/whitelist being a racially loaded term regarding the associated attributes to black and white (see also here) the former naming is also not self-explanatory to a non-technical person and/or non-native speaker. Exclusion or inclusion in turn makes it obvious what clicking the tag does.