Pull request can be merged after commits after approval.

[GokhanBond]

Hello!

First of all, it is great to see there is a community answering and helping each other.
Last week I have found a unexpected flow whilst pull requesting/merging. Let me explain the situation and what I find weird.

1. I have created a pull request from to . The development has a prerequisite to have at least 1 approval.
2. A colleague has approved my beautiful changes. but no merge has been done yet.
3. I found a small mistake in the code and could change it directly within GitHub.
4. The pull request was still mergable.

So my question is, why can I still merge it? I did change the code after the approval.
I truly did expect it would 'undo' approval.

Can someone explain this to me?
Thanks in advance 😄

[MitkoVtori]

Hi, the problem is in the branch protectinon rules. If you're the owner, just go and add this rule, if you're not, tell someone with permissions to change this:

This should be enabled so when you push new changes you won't be able to merge until someone approve again.

[GokhanBond]

Ah, I see. The IT-guy is the owner of the repositories, and I have already asked for permission, or to change the rules, as you have showed.
Thanks for your amazing reply! It is super helpful!

[ossanna16]

Hi there @GokhanBond and welcome to our community! Thank you for asking a great question 🙂