Version.parse: return Version::NULL for unparseable strings

orn688 · Nov 10, 2016 · fbcf500 · fbcf500
1 parent 9bac107
commit fbcf500
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Library/Homebrew/test/testing_env.rb b/Library/Homebrew/test/testing_env.rb
@@ -36,7 +36,7 @@ def assert_version_detected(expected, url, specs = {})
     end
 
     def assert_version_nil(url)
-      assert_nil Version.parse(url)
+      assert Version.parse(url).null?
     end
   end
 

diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb
@@ -287,7 +287,7 @@ def tokenize
 
   def self.parse(spec)
     version = _parse(spec)
-    new(version) unless version.nil?
+    version.nil? ? NULL : new(version)
   end
 
   def self._parse(spec)