@ashfurrow => Dsl refactor #77
Conversation
|
Initially, there were two |
| @@ -7,7 +7,7 @@ | |||
| // | |||
|
|
|||
| #import <ARAnalytics/ARAnalytics.h> | |||
| #import <ReactiveCocoa/RACTuple.h> | |||
| #import <Aspects/NSObject+Aspects.h> | |||
There was a problem hiding this comment.
(API-Question) Would it be cleaner if I change it to <Aspects/Aspects.h> ?
There was a problem hiding this comment.
Will change this in 1.1 to <Aspects/Aspects.h>.
Also changed aspect_remove:. Adding aspects now returns id<Aspect> which has one method, remove. Sorry for the API changes :)
There was a problem hiding this comment.
All super cool to me, will update tomorrow morning 👍
|
Super cool! Yeah I'll have to move some Artsy stuff around. I'll wait until the 1.1 release of aspects? |
|
Just pushed the 1.1. Also adds a myriad of test cases and tries to clean up everything on aspect removal. There's one downside that makes me a bit sad, see steipete/Aspects#2. But that's really no different for ReactiveCocoa... and I doubt that this will affect your use case. |
|
rock |
|
will fix up tomorrow morning with |
|
rock, updated. |
|
|
|
I'm good to issue a release? |
|
U gonna hate me, but I've refined the API once more in 1.3. I hope that's it now. Position became options, and for the flow I had to change the withBlock to usingBlock. |
|
No problemo. I'll get on that. |
Hello there, decided to devote some time to cleanup & tests since you've now done all the hard work.
Switched to @steipete's Aspect library, ( /cc Pete, found it a bit odd that the API for removal of aspects is a class method, yet theres a different API for classes and instances. ) which changed the block params to be an NSArray of the arguments. This is a breaking change for the Artsy stuff you've been doing I imagine 😉 🍷
I found it a bit hard to write some more of the tests, as state would leak between tests. so I added a way to add / remove / remove all to the public API.
I also tightened up the example JSON, I like the idea of being super specific with the tabbing, but for examples I'd rather it be more readable. One day I'll make a ruby script to tab these things, doing it in Xcode is a massive hassle.
( there's also a bunch of cleanup around the project in here too to make it fancier )