fix(cli): changes file paths to relative paths for the registry client #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpower432
force-pushed
the
bug/relative-path-titles
branch
from
a7258ae
to
c23b455
Compare
|
@jpower432 I actually was going to submit an issue related to the annotation title so im glad that it s being tackled as part of this issue |
Since the build path is in a disposable directory, it cannot be included in the "title" annotation on the artifacts. To fix this, relative paths within the workspace are passed to the oras client and the directory is changed before processing. Closes ortelius#10 Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
Signed-off-by: Jennifer Power <barnabei.jennifer@gmail.com>
jpower432
force-pushed
the
bug/relative-path-titles
branch
from
c23b455
to
f326a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the build path is in a disposable directory, it cannot be included
in the "title" annotation on the artifacts. To fix this, relative paths within
the workspace are passed to the oras client and the directory is changed before
processing.
Closes #10
Signed-off-by: Jennifer Power barnabei.jennifer@gmail.com