Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config schema not available for v0.6.0+ #1331

Closed
nickdbush opened this issue May 11, 2021 · 2 comments · Fixed by #1359
Closed

Config schema not available for v0.6.0+ #1331

nickdbush opened this issue May 11, 2021 · 2 comments · Fixed by #1359
Assignees
@zepatrik
Labels
bug Something is not working.

Comments

@nickdbush
Copy link
Contributor

Describe the bug

For v0.5.5-alpha.1 (and prior), the JSON schema for the configuration file was found at https://raw.githubusercontent.com/ory/kratos/v0.5.5-alpha.1/.schema/config.schema.json.

v0.6.0-alpha.1 and v0.6.0-alpha.2 do not have the config.schema.json file in the `.schema directory. This causes a 404 for the https://raw.githubusercontent.com/ory/kratos/v0.6.0-alpha.2/.schema/config.schema.json resource.

The config schemas for v0.6.0+ are referenced in the schemastore.org schema.

This prevents IntelliSense and validation from working in compatible editors for v0.6.0+ configs.

Reproducing the bug

  1. Open VSCode
  2. Create a kratos.yml file
  3. Observe that IntelliSense works for the version key. Set version: v0.6.0-alpha.2
  4. Observe that IntelliSense fails to find the schema for the rest of the configuration options.

Expected behaviour

Autocomplete is populated with available configuration options for v0.6.0+ configs.

Environment

  • Version: v0.6.0-alpha.2
  • Environment: Windows, VScode
@zepatrik
Copy link
Member

Right, sorry for that. The config schema moved but we forgot to update the release automation.

@zepatrik zepatrik self-assigned this May 12, 2021
@aeneasr aeneasr added the bug Something is not working. label May 12, 2021
@aeneasr
Copy link
Member

aeneasr commented May 18, 2021

@zepatrik could you make a PR for this?

@zepatrik zepatrik mentioned this issue May 18, 2021
Merged
aeneasr pushed a commit that referenced this issue May 18, 2021
@zepatrik
fix: version schema (#1359)
8c4bac7 
Closes #1331
Closes #1101

This fixes the config schema paths in the version.schema.json to reflect the new path since we use go embed.

See also ory/hydra#2427

The CI was also updated to include the new schema path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepatrik zepatrik

Labels
bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: version schema ory/kratos
3 participants
@aeneasr @zepatrik @nickdbush