Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default arg parser to typer #117

Merged
merged 6 commits into from
May 9, 2024

Conversation

jhonnye0
Copy link
Contributor

@jhonnye0 jhonnye0 commented May 3, 2024

Pull Request description

Change the default arg parser to typer

How to test these changes

  • Run smoke and unit tests to see if there's no errors

  • use the new cli sugar --help

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab
Copy link
Member

xmnlab commented May 6, 2024

@jhonnye0 , thanks for working on that!

the CI is failing here: https://github.com/osl-incubator/sugar/actions/runs/8933790095/job/24539743195?pr=117#step:5:10

you need to remove the poetry.lock and generate it again with poetry lock
maybe it is not necessary to remove .. as it will generate it again .. but just in case I remove it to be sure about the result

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonnye0 in general looks really good. thanks for working on that.
maybe as a follow-up it would be nice to create these commands dynamically from some kind of schema

src/sugar/cli.py Outdated Show resolved Hide resolved
src/sugar/cli.py Outdated Show resolved Hide resolved
@jhonnye0 jhonnye0 requested a review from xmnlab May 8, 2024 02:55
@xmnlab
Copy link
Member

xmnlab commented May 8, 2024

@jhonnye0 it seems that it has some issues with poetry ...
probably the best way to fix that is to remove poetry.lock and run poetry lock again

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @jhonnye0 !

it would be nice to have a follow up to make it create the typer commands dynamically from schema ... let me know if you would like on that as well :)

it is really a great new feature for the project :)

appreciate that.

@xmnlab xmnlab merged commit b9def08 into osl-incubator:main May 9, 2024
9 checks passed
Copy link

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants