-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default arg parser to typer #117
Conversation
@jhonnye0 , thanks for working on that! the CI is failing here: https://github.com/osl-incubator/sugar/actions/runs/8933790095/job/24539743195?pr=117#step:5:10 you need to remove the poetry.lock and generate it again with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhonnye0 in general looks really good. thanks for working on that.
maybe as a follow-up it would be nice to create these commands dynamically from some kind of schema
@jhonnye0 it seems that it has some issues with poetry ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @jhonnye0 !
it would be nice to have a follow up to make it create the typer commands dynamically from schema ... let me know if you would like on that as well :)
it is really a great new feature for the project :)
appreciate that.
🎉 This PR is included in version 1.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Pull Request description
Change the default arg parser to typer
How to test these changes
Run smoke and unit tests to see if there's no errors
use the new cli sugar --help
...
Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: