Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add default config for project-name #82

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Jul 17, 2023

Pull Request description

  • Add default config for project-name. It also allows to use environment variable for the default project-name
  • Split the smoke tests in smaller tests
  • Kill all the container before starting a new test
  • Replace all the usage of kxgr to sugar (kxgr is still a valid alias for containers-sugar)
  • Fix default services list used from the configuration file

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved .

@xmnlab
Copy link
Member Author

xmnlab commented Jul 17, 2023

@EverVino this PR is ready for review if you have time :)

@xmnlab
Copy link
Member Author

xmnlab commented Jul 17, 2023

@EverVino I am merging this PR, but feel free to add any comment here and I can address that in a follow-up

@xmnlab xmnlab merged commit 1dab380 into osl-incubator:main Jul 17, 2023
5 checks passed
@xmnlab xmnlab deleted the add-option-for-custom-project-name branch July 17, 2023 19:09
@github-actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant